Optimize special functions with help of JMP_FRAMELESS #18592
+118
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
May 18, 2025
| // zend_result (*handler)(znode *, zend_ast_list *); | ||
| } zend_special_func; | ||
|
|
||
| static const zend_special_func zend_special_func_compile_handlers[] = { |
There was a problem hiding this comment.
There should be a comment with the definition of the explicitly listed functions, ie. what they need to meet and if not all are listed, why only smaller subset is listed.
|
Nice! The idea makes sense to me. JMP_FRAMELESS is unfortunately a bit of a misnomer. |
It's only a 0.16% diff on Valgrind ICount, so I'm not sure this is worth pursuing. Although some tests fail so perhaps something is still missed where the optimization is unoptimal, but it's already an indication this won't be a big win. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-blocked by #18591