Skip to content

Intl: Add a new IntlListFormatter class #18519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Intl: Add a new IntlListFormatter class #18519

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ea1ee1c
Intl: Add IntlListFormatter class
BogdanUngureanu May 7, 2025
9236166
Skip test if ICU is older than 67
BogdanUngureanu May 7, 2025
29f0ebb
Call ZEND_PARSE_PARAMETERS_NONE in getErrorCode and getErrorMessage
BogdanUngureanu May 8, 2025
a2dd8e9
Make IntlListFormatter final, not serializable and use strict properties
BogdanUngureanu May 8, 2025
e31bfe4
Added more validation for parameters and fixed coding style
BogdanUngureanu May 9, 2025
8524fdc
Attempt to fix the windows build failure
BogdanUngureanu May 9, 2025
a096a14
Simplify the implementation
BogdanUngureanu May 10, 2025
7ef1380
Fix leak and simplify error handling
BogdanUngureanu May 11, 2025
6852001
Add more tests
BogdanUngureanu May 11, 2025
3851509
use safe_emalloc
BogdanUngureanu May 12, 2025
1f64694
Hide unavailable constants for ICU < 67 and remove comments
BogdanUngureanu May 13, 2025
7b55c89
update error message
BogdanUngureanu May 14, 2025
a7e9a29
use exception
BogdanUngureanu May 15, 2025
5d2ca4c
disable cloning and use different functions
BogdanUngureanu May 16, 2025
c5917a8
Fix typo and code style
BogdanUngureanu May 16, 2025
a792f88
Remove redundant condition and add php closing tag in tests
BogdanUngureanu May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip test if ICU is older than 67
  • Loading branch information
@BogdanUngureanu
BogdanUngureanu committed May 7, 2025
commit 9236166f72d2d924d4ea46ab39238641b2f69f4c
2 changes: 2 additions & 0 deletions ext/intl/tests/listformatter/listformatter_with_paramaters.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
IntlListFormatter: Test AND, OR and Width parameters
--EXTENSIONS--
intl
--SKIPIF--
<?php if (version_compare(INTL_ICU_VERSION, '67.0') >= 0) die('skip for ICU < 67.0'); ?>
--FILE--
<?php

Expand Down
Loading