Skip to content

ext/libxml: Various minor refactorings #18429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 26, 2025
Merged

ext/libxml: Various minor refactorings #18429

merged 6 commits into from
Apr 26, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Apr 26, 2025

Commits should be reviewed in order

@Girgias Girgias marked this pull request as ready for review April 26, 2025 11:46
nielsdos
nielsdos approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the signature change can go in UPGRADING so we don't forget updating the docs

@Girgias Girgias merged commit 3932d9b into php:master Apr 26, 2025
9 checks passed
@Girgias Girgias deleted the libxml-refacto branch April 26, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees

No one assigned

Labels

ABI break Extension: libxml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Girgias @nielsdos