Avoid allocation in zend_enum_get_case_cstr()#18239
Merged
ndossche merged 1 commit intophp:masterfrom Apr 4, 2025
Merged
Conversation
Future uses of this internal API are planned, and we can easily avoid an allocation by factoring out the common code.
Girgias
approved these changes
Apr 3, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
MSTM.
Follow-up, maybe there should be a new ZEND_API that takes a C string with its length to prevent the strlen() computation for literal strings?
Member
Author
Sure. Will do that for my other work that prompted this PR (soon). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future uses of this internal API are planned, and we can easily avoid an allocation by factoring out the common code.