Closed
Conversation
iluuu1994
force-pushed
the
gh-18050
branch
3 times, most recently
from
6e15a49 to
dba894d
Compare
ndossche
reviewed
Mar 16, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
It looks right, please see my question to double check
ndossche
approved these changes
Mar 16, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Leaving target branch decision for other people
dstogov
approved these changes
Mar 17, 2025
Member
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
I don't see problems. I think this may be merged into PHP-8.4.
in_array() calls are compiled to frameless calls. Adjust the optimization appropriately. Luckily, frameless opcodes simplify the optimization quite a bit. Fixes phpGH-18050
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in_array() calls are compiled to frameless calls since PHP 8.4. Adjust the optimization appropriately. Luckily, frameless opcodes simplify the optimization quite a bit.
Fixes GH-18050
I'm not sure if this should land on
master? Technically a bug, but the fix is not risk-free.