Relax test expectation for pcre2lib 10.45 #18029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @nielsdos as this is part of your commit in master |
nielsdos
approved these changes
Mar 12, 2025
|
Actually looks like circleci failure is related to the test. Is there a double whitespace that you now have in th expect section? |
nielsdos
requested changes
Mar 12, 2025
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
|
OK reproduce locally, failure is with old version. Now test passes (locally) with old and new pcre |
|
Applied in 8.3+ as 69480be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using e928487