Skip to content

Reflection: indicate final and abstract properties in string output #17827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ext/reflection/php_reflection.c
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,12 @@ static void _property_string(smart_str *str, zend_property_info *prop, const cha
if (!prop) {
smart_str_append_printf(str, "<dynamic> public $%s", prop_name);
} else {
if (prop->flags & ZEND_ACC_ABSTRACT) {
smart_str_appends(str, "abstract ");
}
if (prop->flags & ZEND_ACC_FINAL) {
smart_str_appends(str, "final ");
}
/* These are mutually exclusive */
switch (prop->flags & ZEND_ACC_PPP_MASK) {
case ZEND_ACC_PUBLIC:
Expand Down
42 changes: 42 additions & 0 deletions ext/reflection/tests/abstract_property_indicated.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
--TEST--
Output of properties indicates if they are abstract
--FILE--
<?php

abstract class Demo {
abstract public $a { get; }
public $b;
}

$class = new ReflectionClass(Demo::class);
echo $class;

$propA = new ReflectionProperty(Demo::class, 'a');
echo $propA;

$propB = new ReflectionProperty(Demo::class, 'b');
echo $propB;
?>
--EXPECTF--
Class [ <user> <iterateable> abstract class Demo ] {
@@ %s %d-%d

- Constants [0] {
}

- Static properties [0] {
}

- Static methods [0] {
}

- Properties [2] {
Property [ abstract public $a ]
Property [ public $b = NULL ]
}

- Methods [0] {
}
}
Property [ abstract public $a ]
Property [ public $b = NULL ]
2 changes: 1 addition & 1 deletion ext/reflection/tests/asymmetric_visibility_flags.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ bool(true)
bool(false)
bool(true)
bool(false)
Property [ public private(set) int $bar ]
Property [ final public private(set) int $bar ]
bool(false)
bool(true)
bool(false)
Expand Down
42 changes: 42 additions & 0 deletions ext/reflection/tests/final_property_indicated.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
--TEST--
Output of properties indicates if they are final
--FILE--
<?php

class Demo {
final public $a;
public $b;
}

$class = new ReflectionClass(Demo::class);
echo $class;

$propA = new ReflectionProperty(Demo::class, 'a');
echo $propA;

$propB = new ReflectionProperty(Demo::class, 'b');
echo $propB;
?>
--EXPECTF--
Class [ <user> class Demo ] {
@@ %s %d-%d

- Constants [0] {
}

- Static properties [0] {
}

- Static methods [0] {
}

- Properties [2] {
Property [ final public $a = NULL ]
Property [ public $b = NULL ]
}

- Methods [0] {
}
}
Property [ final public $a = NULL ]
Property [ public $b = NULL ]
Loading