ext/snmp: Add null check for uninitialized SNMP session in security level setter #17332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel setter This change introduces a validation step in the `netsnmp_session_set_sec_level` function to ensure that the SNMP session is properly initialized before attempting to set the security level. If the session is not initialized, a zend_value_error is triggered, improving error handling and preventing potential crashes.
|
Thanks but I had a slightly different approach in mind, will commit soon-ish :) |
|
Hi @evrenonur and thanks for your effort however a fix had been pushed since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a validation step in the
netsnmp_session_set_sec_levelfunction to ensure that the SNMP session is properly initialized before attempting to set the security level. If the session is not initialized, a zend_value_error is triggered, improving error handling and preventing potential crashes.Fixes: #17330