Skip to content

sapi/cli: Refactor process title setting code #17177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

sapi/cli: Refactor process title setting code #17177

merged 1 commit into from
Dec 16, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 16, 2024

@Girgias Girgias marked this pull request as ready for review December 16, 2024 17:08
@Girgias Girgias requested a review from nielsdos December 16, 2024 17:08
nielsdos
nielsdos approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a behaviour change that may need to get documented in UPGRADING, but otherwise I think this is fine.

@Girgias Girgias merged commit d21777d into php:master Dec 16, 2024
10 checks passed
@Girgias Girgias deleted the title-cli-refactor branch December 16, 2024 22:50
Girgias added a commit that referenced this pull request Dec 16, 2024
@Girgias
[skip ci] Add upgrading entry for GH-17177
c8bbb2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
SAPI: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nielsdos