ext/dba/tests/gh16390.phpt: skip if inifile is disabled #17011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test reads an ini "file" from a string, and expects a warning about locking. But if inifile support is disabled, then you'll get Warning: dba_open(): Handler "inifile" is not available in /path/to/ext/dba/tests/gh16390.php on line 3 instead. We skip the test if inifile support is disabled.
4 tasks
|
Thank you! Should probably applied to PHP 8.2. |
Girgias
approved these changes
Dec 2, 2024
cmb69
reviewed
Dec 2, 2024
Comment on lines
+7
to
+8
| require_once __DIR__ . '/setup/setup_dba_tests.inc'; | ||
| check_skip('inifile'); |
There was a problem hiding this comment.
Comparing this with the SKIPIF section of https://github.com/php/php-src/pull/17005/files#diff-0f4f5dbb2a00f5b3a7c047f212cb553bbf1e3112ebe500f52b2188222a746260R9-R10, I wonder what's the preferred way nowadays.
There was a problem hiding this comment.
Ha, this happens every time I add a SKIPIF. They both get the job done, but the check_skip() function is a bit newer so I placed my bet on that.
I do not |
|
I'll merge this in 8.3 and up, thanks! |
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
This test reads an ini "file" from a string, and expects a warning about locking. But if inifile support is disabled, then you'll get Warning: dba_open(): Handler "inifile" is not available in /path/to/ext/dba/tests/gh16390.php on line 3 instead. We skip the test if inifile support is disabled. Closes phpGH-17011.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test reads an ini "file" from a string, and expects a warning about locking. But if inifile support is disabled, then you'll get
instead. We skip the test if inifile support is disabled.