Silent rules #1659
Closed
Silent rules #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using output from automake as a guide, define macros which can be prepended to build rules which generate nice, clean, readable build output like this... CC ext/opcache/ZendAccelerator.lo CC ext/opcache/zend_accelerator_blacklist.lo CC ext/opcache/zend_accelerator_debug.lo CC ext/opcache/zend_accelerator_hash.lo CC ext/opcache/zend_accelerator_module.lo
This is the main guts of the build system where the build silent build rules need to be applied. Most of the objects are build from these rules.
|
There doesn't seem to be any interest in this whatever. I think I know why: It is sometimes useful when a build fails to be able to see and copy the last command, and possibly execute it, without having to rebuild or pass special environment to make. I think there is no value added here, so I'm closing the PR. If you think I'm wrong to do that, please start an internals discussion and try to gather a consensus, I'd be happy to merge a PR with consensus that it's a good idea, in opposition to my own opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few patches which add silent rules to the php build system. To test, generate the build system and run either 'make' or 'make V=1'. This may need additional testing so please don't blindly pull.
Silent output looks like this...
CC ext/date/lib/parse_tz.lo
CC ext/date/lib/timelib.lo
CC ext/date/lib/tm2unixtime.lo
CC ext/date/lib/unixtime2tm.lo