Skip to content

GH-16504: avoid seg fault when creating new lazy class instance fails #16506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

GH-16504: avoid seg fault when creating new lazy class instance fails #16506

wants to merge 1 commit into from

Conversation

DanielEScherzer
Copy link
Member

No description provided.

@DanielEScherzer DanielEScherzer changed the base branch from master to PHP-8.4 October 19, 2024 10:35
@DanielEScherzer
Copy link
Member Author

Misclick, sorry for the spam!

@arnaud-lb
Copy link
Member

Thank you @DanielEScherzer! I think this fixes the same issue as #15856.

@DanielEScherzer
Copy link
Member Author

Thank you @DanielEScherzer! I think this fixes the same issue as #15856.

Okay, before I spend time to work on fixing up the failures here, do you plan on merging that one soon? If yes, then I'll just wait for that and re-test the original report, but I agree it should be fixed by that patch too

@arnaud-lb
Copy link
Member

I think I'm going to merge that one today

@arnaud-lb
Copy link
Member

I've merged #15856. I confirm that it fixes the same issue

@DanielEScherzer
Copy link
Member Author

Okay

@DanielEScherzer DanielEScherzer deleted the lazy-clone branch October 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb Awaiting requested review from arnaud-lb

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielEScherzer @arnaud-lb