Skip to content

GH-15911: prevent appending an AppendIterator to itself #16492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: PHP-8.2
Choose a base branch
from
Open

GH-15911: prevent appending an AppendIterator to itself #16492

wants to merge 2 commits into from
+65 −0

Conversation

DanielEScherzer
Copy link
Member

No description provided.

@DanielEScherzer DanielEScherzer changed the base branch from master to PHP-8.2 October 18, 2024 04:12
@DanielEScherzer
Copy link
Member Author

<force pushed to trigger CI since I accidentally opened this against master and switching branches doesn't trigger jobs>

@DanielEScherzer DanielEScherzer mentioned this pull request Oct 18, 2024
Open
@nielsdos
Copy link
Member

This doesn't fix the problem in general.
Suppose we have two append iterators A and B. We can add A to B and B to A and we'll have the same issue.

@DanielEScherzer
Copy link
Member Author

This doesn't fix the problem in general. Suppose we have two append iterators A and B. We can add A to B and B to A and we'll have the same issue.

Unfortunately, this isn't a part of the code base I'm very familiar with, but I took a crack at that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

Assignees

No one assigned

Labels

ABI break Extension: spl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielEScherzer @nielsdos