Fix GH-16473: dom_import_simplexml stub is wrong #16489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been wrong since PHP 8.0 at least, and the signature was inherited in 8.4-dev to the new DOM methods.
cmb69
added a commit
to cmb69/doc-en
that referenced
this pull request
Oct 17, 2024
cmb69
approved these changes
Oct 17, 2024
cmb69
added a commit
to php/doc-en
that referenced
this pull request
Oct 19, 2024
* Fix dom_import_simplexml() return type (see <php/php-src#16489>) * Fix return values section, too * Update function and parameter descriptions * Clarify aliasing/view behavior and add example Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been wrong since PHP 8.0 at least, and the signature was inherited in 8.4-dev to the new DOM methods.
Note for self: when merging up also fix the variant in the Dom namespace in 8.4-dev.