Skip to content

ext/[cd]*: fix a bunch of typos #16298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

ext/[cd]*: fix a bunch of typos #16298

merged 1 commit into from
Oct 9, 2024

Conversation

DanielEScherzer
Copy link
Member

Only functional change is the renaming of the functions dom_document_substitue_entities_(read|write) to replace substitue with substitute.

@DanielEScherzer
ext/[cd]*: fix a bunch of typos
234cd4f 
Only functional change is the renaming of the functions
`dom_document_substitue_entities_(read|write)` to replace `substitue` with
`substitute`.
iluuu1994
iluuu1994 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for Niels to confirm the DOM changes, but as they are not public API it should be unproblematic.

nielsdos
nielsdos approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nielsdos nielsdos merged commit 41996e8 into php:master Oct 9, 2024
10 checks passed
@nielsdos
Copy link
Member

nielsdos commented Oct 9, 2024

Merged, thanks!

@DanielEScherzer DanielEScherzer deleted the more-typos branch October 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees

No one assigned

Labels

Extension: calendar Extension: com_dotnet Extension: ctype Extension: curl Extension: date Extension: dba Extension: dom

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielEScherzer @nielsdos @iluuu1994