Fix regression on platforms without ZEND_CHECK_STACK_LIMIT set (8.4)
#16285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a guard on one instance of this, but not the other. Unsure if this is the best place for this; the functions are `#ifdef` gated in `zend_execute.c`, but not the associated header; perhaps it should be `#else` with a nop version of the function in that case? I added a guard at this call site to be consistent with other places.
NattyNarwhal
changed the title
ZEND_CHECK_STACK_LIMIT set (8.4)
arnaud-lb
reviewed
Oct 7, 2024
Co-authored-by: Arnaud Le Blanc <arnaud.lb@gmail.com>
|
Would like another review before I tag RC2 tomorrow; if it's good, I'll merge it. |
NattyNarwhal
added a commit
that referenced
this pull request
Oct 8, 2024
* PHP-8.4: Fix regression on platforms without `ZEND_CHECK_STACK_LIMIT` set (8.4) (#16285)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a guard on one instance of this, but not the other. Unsure if this is the best place for this; the functions are
#ifdefgated inzend_execute.c, but not the associated header; perhaps it should be#elsewith a nop version of the function in that case? I added a guard at this call site to be consistent with other places.8.4 targeting version of GH-16284, obsoletes that.