Support bug64159.phpt on Windows CI #15895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test queries `extOutput` for the first line of output of the command which was executed when snmpd started (`HexTest` in snmpd.conf). Since there is no `/bin/sh` on Windows, no command would be run, and as such we received an empty string. We fix that by dynamically adjusting snmpd.conf to run a JScript which has the same output as bigtest. We also make the test diff more helpful in case of failures, where so far we only would have known that the output had a different message digest.
cmb69
force-pushed
the
cmb/bug64159.phpt
branch
from
6e9a506 to
eb45206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test queries
extOutputfor the first line of output of the command which was executed when snmpd started (HexTestin snmpd.conf). Since there is no/bin/shon Windows, no command would be run, and as such we received an empty string. We fix that by dynamically adjusting snmpd.conf to run a JScript which has the same output as bigtest.We also make the test diff more helpful in case of failures, where so far we only would have known that the output had a different message digest.