ext/curl: Add CURLINFO_POSTTRANSFER_TIME_T support
#15849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI will skip the test because none of the default repos include curl 8.10, but I did run the tests on a custom curl build. I also intentionally did not add this to the |
devnexen
reviewed
Sep 12, 2024
|
seems useful additional info otherwise. |
Ayesh
force-pushed
the
curl-8-10-consts
branch
from
ba873af to
3d26eb6
Compare
|
look fine by me, kind of new feature tough. |
Ayesh
force-pushed
the
curl-8-10-consts
branch
from
3d26eb6 to
1545c1d
Compare
|
Thank you for your review @devnexen. |
Ayesh
force-pushed
the
curl-8-10-consts
branch
3 times, most recently
from
c4d792b to
02bdd6f
Compare
|
Since it's a very minor change, I think I can merge this. Please resolve conflicts before merging. |
SakiTakamachi
approved these changes
Sep 24, 2024
libcurl ref: [`CURLINFO_POSTTRANSFER_TIME_T`](https://curl.se/libcurl/c/CURLINFO_POSTTRANSFER_TIME_T.html) `CURLINFO_POSTTRANSFER_TIME_T` is a libcurl info option that returns the time it took to "post" the transfer. Available since libcurl 8.10.0 This value is also exposed as `posttransfer_time_us` in the `curl_getinfo()` return value when the `$option` parameter is not passed.
Ayesh
force-pushed
the
curl-8-10-consts
branch
from
02bdd6f to
ce13d49
Compare
|
Thank you @SakiTakamachi. I rebased and force-pushed. |
|
Thank you! |
Girgias
pushed a commit
to php/doc-en
that referenced
this pull request
Nov 16, 2024
Commit: php/php-src#15849 PHP.Watch: [PHP 8.4: Curl: `curl_getinfo` - `CURLINFO_POSTTRANSFER_TIME_T` support](https://php.watch/versions/8.4/CURLINFO_POSTTRANSFER_TIME_T)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcurl ref:
CURLINFO_POSTTRANSFER_TIME_TCURLINFO_POSTTRANSFER_TIME_Tis a libcurl info option that returns the time it took to "post" the transfer. Available since libcurl 8.10.0This value is also exposed as
posttransfer_time_usin thecurl_getinfo()return value when the$optionparameter is not passed.