Fix GH-15690: ext-dba failures on 32-bit #15691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong type was used in the size calculation. On 64-bit this coincidentally doesn't cause issues, but on 32-bit it does because of different padding vs 64-bit resulting in a different size. Regressed in 2097237.
|
Thank you! Some unrelated change must have changed memory layout in a way that triggered the issue. We should probably use ASan for one 32-bit job. |
Without digging too deep into this (I already closed my VM): addition of flags member of zend_object probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong type was used in the size calculation. On 64-bit this coincidentally doesn't cause issues, but on 32-bit it does because of different padding vs 64-bit resulting in a different size.
Regressed in 2097237.