Autotools: Normalize PHP_ADD_BUILD_DIR 1st argument #15612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
requested review from
bukka,
dstogov,
iluuu1994,
devnexen,
nielsdos and
Girgias
as code owners
nielsdos
approved these changes
Aug 28, 2024
devnexen
approved these changes
Aug 28, 2024
The m4_normalize(m4_expand([$1])) expands the given argument if it contains M4 macros, and then trims the items together into a space separated string in an intuitive way.
petk
force-pushed
the
patch-normalize-PHP_ADD_BUILD_DIR
branch
from
cc637cd to
2abfe6c
Compare
|
Has been rechecked again and all seems to be ok here. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The m4_normalize(m4_expand([$1])) expands the given argument if it contains M4 macros, and then trims the items together into a space separated string in an intuitive way.
From my tests, I think this is still "safe" to put to PHP-8.4 branch as it already works the same also without m4_normalize() in PHP-8.3 and earlier due to those double quotes used around the 1st argument variable. That's why I'm targeting it already.