Skip to content

ext/opcache/ZendAccelerator.c: Restrict MD5 header include to Windows #15418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

ext/opcache/ZendAccelerator.c: Restrict MD5 header include to Windows #15418

merged 1 commit into from
Aug 15, 2024

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Aug 14, 2024

As it is only ever used in accel_gen_uname_id() which is Windows only

@Girgias
ext/opcache/ZendAccelerator.c: Restrict MD5 header include to Windows
3bec496 
As it is only ever used in accel_gen_uname_id() which is Windows only
@Girgias Girgias force-pushed the accelerator-header branch from 436a655 to 3bec496 Compare August 14, 2024 23:48
cmb69
cmb69 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess that has been overlooked when zend_system_id had been split.

(We may want to review the use of md5 here and in zend_system_id. /cc @TimWolla)

petk
petk approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I also didn't check for the ext/standard extension back then at GH-14682

@Girgias Girgias merged commit 3e226af into php:master Aug 15, 2024
@Girgias Girgias deleted the accelerator-header branch August 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petk petk petk approved these changes

@cmb69 cmb69 cmb69 approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees

No one assigned

Labels

Extension: opcache

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Girgias @petk @cmb69