Skip to content

session.save_handler - add two uncovered cases #15337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2024
Merged

session.save_handler - add two uncovered cases #15337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d9fcaf
Added two uncovered cases
jorgsowa Aug 11, 2024
729ebb6
Added error name to test output
jorgsowa Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ext/session/tests/user_session_module/session_set_save_handler_error5.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
Test session_set_save_handler() function : error functionality
--EXTENSIONS--
session
--INI--
session.save_handler=
--FILE--
<?php
try {
session_set_save_handler(new \SessionHandler(), true);
session_start();
} catch (Throwable $e) {
echo $e->getMessage() . "\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefer seeing what exception is being thrown

Suggested change
echo $e->getMessage() . "\n";
echo $e::class . ': ' . $e->getMessage() . "\n";

Copy link
Contributor Author

@jorgsowa jorgsowa Aug 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to push?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry. Internet connection interruption.

}
echo "ok";
?>
--EXPECT--
Cannot call default session handler
ok
19 changes: 19 additions & 0 deletions ext/session/tests/user_session_module/session_set_save_handler_error6.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
Test session_set_save_handler() function : error functionality
--EXTENSIONS--
session
--INI--
session.save_handler=
--FILE--
<?php
ob_start();

session_start();
session_set_save_handler(new \SessionHandler(), true);

echo "ok";
ob_end_flush();
?>
--EXPECTF--
Warning: session_start(): Cannot find session save handler "" - session startup failed in %s on line %d
ok