ValueError on null byte in session_name()

[jorgsowa]

Prevents setting session name with null byte through the session_name() function.

[cmb69]

Can't we just apply the following patch instead:

 ext/session/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/session/session.c b/ext/session/session.c
index f3296e37f2..c69409fdb4 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -1865,7 +1865,7 @@ PHP_FUNCTION(session_name)
 	zend_string *name = NULL;
 	zend_string *ini_name;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "|S!", &name) == FAILURE) {
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "|P!", &name) == FAILURE) {
 		RETURN_THROWS();
 	}

[jorgsowa]

Thanks for the comment. I limited only to flag P of session_name()'s input.

[Girgias]

LGTM with minor nit

[Girgias]

Thank you!