Update ext/sodium preprocessor macro help texts #15270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sodium extension was initially named "libsodium" in PECL and was renamed to sodium when it was bundled to php-src. The HAVE_LIBSODIUMLIB symbol here could indicate that PHP extension sodium is available. Otherwise the macro is not used in the current code base. Header php_libsodium.h became "installed"/public as of PHP-8.4. [skip ci]
devnexen
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the left overs for PHP-8.4 because the ext/sodium/php_libsodium.h header is installed as of PHP-8.4.
The sodium extension was initially named "libsodium" in PECL and was renamed to sodium when it was bundled to php-src. The HAVE_LIBSODIUMLIB symbol here could indicate that PHP extension sodium is available.
Otherwise this macro is not used in the current code base. Should perhaps this one be removed or renamed? Or should even the php_libsodium.h be removed from the installed headers?