use libedit instead of readline for CI #15194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last time, the issue was here that phpdbg is failing the tests #13199 (when using the --enable-phpdbg-readline option). I guess current .github files don't have this option enabled. |
Yes, I remember now fully. This is separate issue related to only --enable-phpdbg-readline configure option so this PR works ok. And also this issue has been now fixed in PHP-8.2 and up so phpdbg with libedit/readline integration should works. |
petk
approved these changes
Aug 2, 2024
|
Thanks for reviews Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to recent failure (8.4.0alpha3) because of libedit/readline incompatible
For memory, readline license (GPL) is not compatible with PHP License, so should not be used