Sync HAVE_<extension> help texts #15167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
requested review from
Girgias,
NattyNarwhal,
SakiTakamachi,
adoy,
alexdowad,
bukka,
devnexen,
dstogov,
nielsdos and
youkidearitai
as code owners
github-actions
bot
added
Category: Build System
Extension: openssl
Extension: bcmath
Extension: bz2
Extension: calendar
Extension: com_dotnet
Extension: ctype
Extension: curl
Extension: dba
Extension: dom
Extension: enchant
Extension: exif
Extension: ffi
Extension: ftp
Extension: gmp
Extension: ldap
Extension: libxml
Extension: mbstring
Extension: odbc
Extension: pdo_pgsql
labels
github-actions
bot
added
Extension: shmop
Extension: simplexml
Extension: snmp
Extension: soap
Extension: sockets
Extension: sqlite3
Extension: sysvmsg
Extension: sysvsem
Extension: sysvshm
Extension: tidy
Extension: xml
Extension: xmlreader
Extension: xmlwriter
Extension: xsl
Extension: zip
Extension: zlib
labels
devnexen
approved these changes
Jul 30, 2024
NattyNarwhal
approved these changes
Jul 30, 2024
nielsdos
approved these changes
Jul 30, 2024
SakiTakamachi
approved these changes
Jul 31, 2024
|
In the appended commit, I've only changed the CS in M4 files a bit and used this help text instead (minor grammar correction): |
devnexen
approved these changes
Aug 1, 2024
This syncs all help texts of extension preprocessor macros to the same style "Define to 1 if PHP extension '<ext>' is available.".
To make this sound a bit better and to be a bit in sync with the
COMPILE_DL_<ext>, help texts are:
Define to 1 if the PHP extension 'extension_name' is available.
petk
force-pushed
the
patch-AC_DEFINE-extensions
branch
from
60bcf67 to
48f8d5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs all help texts of extension preprocessor macros to the same style
Define to 1 if PHP extension '<ext>' is available..