Fix type incompatibility in assignment. #15104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts 0956267, which introduced a type incompatibility where an `int` function is assigned to a `zend_result` function. That yields a level 1 C4133 warning on MSVC, and usually (e.g. in CI) level 1 warnings are elevated to errors, so the build fails.[1] The PHP-8.3 branch and up are uneffected by this, so the upward merges should be empty. [1] <php@0956267#r144587696>
Girgias
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
sigh It the function pointer issue thing again... I really dislike the fact that GCC and Clang don't care about this issue, MSVC is actually being sensible here.
And even more frustrating that there is no way to have this warn.....
Feel free to merge, and possibly even have a comment explaning why we have the warning for this version so we don't make this change again.
|
Thank you! I've added a respective comment, and closed via af789af. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts 0956267, which introduced a type incompatibility where an
intfunction is assigned to azend_resultfunction. That yields a level 1 C4133 warning on MSVC, and usually (e.g. in CI) level 1 warnings are elevated to errors, so the build fails.[1]The PHP-8.3 branch and up are uneffected by this, so the upward merges should be empty.
[1] 0956267#r144587696
See https://github.com/php/php-src/actions/runs/10078923540/job/27864997876#step:5:897 for detailed info about the build failure.