Move ext/snmp to pkg-config #15002
Closed
Move ext/snmp to pkg-config #15002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mandates net-snmp 5.4 (which is quite old), and assumes the version of OpenSSL it was built against has EVP_SHA256/512 support (as the version of OpenSSL PHP requires should be guaranteed to have this). pkg-config support in net-snmp materializes in 5.8.1 (from 2019).
|
Windows failure looks like it's missing EVP_SHA256 and friends; I might have to readd the check for that unless it's using a particularly old version. (Not sure where to check where it sources it from; I checked the CI scripts and sdk-binary-tools.) |
|
On Windows, I think that these sources are used: https://github.com/winlibs/net-snmp |
|
Closed because GH-15261 obsoleted this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mandates net-snmp 5.4 (which is quite old), and assumes the version of OpenSSL it was built against has EVP_SHA256/512 support (as the version of OpenSSL PHP requires should be guaranteed to have this).
pkg-config support in net-snmp materializes in 5.8.1 (from 2019).