Autotools: Refactor curl config.m4 #14948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
Jul 13, 2024
petk
commented
- CS synced
- When checking for libcurl linked against old OpenSSL the LIBS can be used instead of LDFLAGS to put -lcurl to proper place. Also, flags manipulation variables are wrapped in the AC_CACHE_CHECK commands because there is also OpenSSL setup done later in the code which changes LDFLAGS, LIBS and/or CFLAGS.
- CFLAGS added to the check to have edge case of -I flags of custom installation paths taken into consideration
- All macro arguments quoted
- SSL check simplified a bit
- The HAVE_CURL symbol help text synced
- CS synced - When checking for libcurl linked against old OpenSSL the LIBS can be used instead of LDFLAGS to put -lcurl to proper place. Also, flags manipulation variables are wrapped in the AC_CACHE_CHECK commands because there is also OpenSSL setup done later in the code which changes LDFLAGS, LIBS and/or CFLAGS. - CFLAGS added to the check to have edge case of -I flags of custom installation paths taken into consideration - All macro arguments quoted - SSL check simplified a bit - The HAVE_CURL symbol help text synced
devnexen
approved these changes
Jul 14, 2024
adoy
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.