Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Improve language coherence for the behaviour of offsets and containers: object handlers #14920

Draft
wants to merge 58 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
7fed0cf
Zend/zend_execute.c: use zend_check_string_offset() for all string of…
Girgias Jan 25, 2024
3043fdd
Zend: Move dimension handlers from object handlers to CE
Girgias Jan 31, 2024
fba8aac
Add assertion and debug check function that interfaces are implemented
Girgias Feb 19, 2024
7a5d0d6
Disable debug
Girgias Feb 20, 2024
400aeb9
Deref offset in VM
Girgias May 28, 2024
dc132a8
ext/simplexml: Convert SimpleXML to new dimension API
Girgias May 28, 2024
8c0679b
ext/dom: Convert DOM classes to new dimension API
Girgias May 28, 2024
18ffb74
ext/intl: Convert ResourceBundle to new dimension API
Girgias Feb 27, 2024
b185ba3
ext/pdo: Convert PDORow to new dimension API
Girgias Feb 27, 2024
95c673f
ext/spl: Convert SplFixedArray to new API
Girgias Feb 27, 2024
a130940
VM call offsetGet when offsetExists returns true
Girgias May 28, 2024
bec7da9
Zend: Convert WeakMap to new dimension API
Girgias May 28, 2024
2739d87
ext/spl: Convert SplObjectStorage to new API
Girgias May 30, 2024
b1902fe
ext/spl: Clean-up SplObjectStorage implementation
Girgias May 30, 2024
afda402
Use static struct for SplObjectStorage dimension handlers
Girgias Jun 8, 2024
bca99ca
ext/spl: [WIP] Convert ArrayObject to new API
Girgias May 31, 2024
d5a9403
ext/ffi: Convert CData to new API
Girgias Feb 21, 2024
676e7c6
Use static struct for function handlers in zend_test
Girgias Jun 8, 2024
9f2cdb7
Use static structs for internal classes
Girgias Jun 8, 2024
e6aa79b
ext/phar: expand test to cover issue with offsetGet
Girgias Jun 7, 2024
6a2cc14
ext/phar: offsetExists should return false when file entry is not bas…
Girgias Jun 7, 2024
0b9f374
Fix append binary op
Girgias Jun 10, 2024
b3f4996
Fix issue when returning object by-ref in fetch
Girgias Jun 10, 2024
01ab9ad
Clean-up implementation of zend_legacy_ArrayAccess_fetch_dimension
Girgias Jun 10, 2024
731cf45
Fix by ref assignments for ArrayObject only
Girgias Jun 10, 2024
864304b
Support indirect, add tests for objects with binary op
Girgias Jun 11, 2024
a619bf3
Fix ArrayAccess for good
Girgias Jun 11, 2024
5c4846a
Fix indirect modification of offset when handler uses global
Girgias Jul 1, 2024
044486d
Improve debug assertion now that conversion is mostly done
Girgias Jul 1, 2024
2b7905c
JIT Support
Girgias Jul 2, 2024
8bb48e0
Do we even need to create a ref?
Girgias Jul 2, 2024
f516c9a
Add missing GMP extension
Girgias Jul 3, 2024
36e2645
ArrayObject arginfos
Girgias Jul 3, 2024
56f60ca
Define default ArrayAccess handlers for internal classes
Girgias Jul 3, 2024
c5e2e05
ext/com: Convert to new API [W.I.P.]
Girgias Jul 3, 2024
d3a5e9d
Remove old dimension handlers
Girgias Jul 3, 2024
c085db5
Fix persistence code in opcache
Girgias Jul 9, 2024
7fcff94
opcache file persistence W.I.P.
Girgias Jul 9, 2024
ed45d0d
Remove unused zend_class_arrayaccess_funcs struct now
Girgias Jul 9, 2024
b40fb05
Have ArrayAccess extend the relevant interfaces
Girgias Jul 11, 2024
c2defa7
Prevent DimensionReadable::offsetGet() to be implemented returning by…
Girgias Jul 11, 2024
a761cee
Add all containers in helper
Girgias Jul 11, 2024
2ab890f
Add test for isset/empty behaviour with all container types
Girgias Jul 11, 2024
c2d76b9
Add tests for increment/decrement on a container offset
Girgias Jul 11, 2024
793db06
Emit warning for RW fetch if offset does not exist
Girgias Jul 12, 2024
898de1e
Error when trying to increment/decrement object offsets
Girgias Jul 13, 2024
5caab8d
Prototype for auto-vivification
Girgias Jul 13, 2024
1157238
Simply increment/decrement check
Girgias Jul 16, 2024
cde9950
Simplify auto-vivification check
Girgias Jul 16, 2024
11e07f9
Use a union to cache zend_function*
Girgias Jul 16, 2024
10f31bc
Test fixes for increment/decrement change
Girgias Jul 16, 2024
3c33e2d
Autovivify via a handler
Girgias Jul 16, 2024
2aea394
Update autovivification change in a test
Girgias Jul 16, 2024
bc5da36
Revert "Update autovivification change in a test"
Girgias Jul 16, 2024
bd77eee
Bodge JIT support again
Girgias Jul 18, 2024
080a2be
Fix property hook test
Girgias Jul 18, 2024
3a53217
Fix opcache pointer serialization after change
Girgias Jul 18, 2024
8e5d564
Fix opline
Girgias Jul 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update autovivification change in a test
  • Loading branch information
Girgias committed Jul 18, 2024
commit 2aea394352a7f642dbe25fd3ab5de803c8fd76c3
10 changes: 7 additions & 3 deletions Zend/tests/offsets/appending_containers_in_fetch.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,17 @@ NULL
Notice: Indirect modification of overloaded element of A has no effect in %s on line %d
Error: Cannot use a scalar value as an array
new B() container:
string(12) "B::offsetSet"
int(5)
string(5) "value"
object(B)#4 (1) {
["storage":"ArrayObject":private]=>
array(1) {
[0]=>
array(1) {
[5]=>
string(5) "value"
object(B)#17 (1) {
["storage":"ArrayObject":private]=>
array(0) {
}
}
}
}