ext/spl: Remove spl_engine.h header#14418
Merged
Girgias merged 2 commits intophp:masterfrom Jun 8, 2024
Merged
Conversation
Girgias
force-pushed
the
spl-engine-remove
branch
from
df4e94d to
e643ee8
Compare
Member
|
To be honest, I found the old code clearer. |
Member
|
Somewhat related #14254. |
Member
Author
It might make sense to have a better API provided by Zend to instantiate an object and run the constructor (e.g. Moreover, I don't really like having other extensions using SPL headers (knowing that with the current state of iterators some extension will include them anyway) |
Member
|
Having a better API that instantiates would be very welcome. |
Girgias
force-pushed
the
spl-engine-remove
branch
from
e643ee8 to
3fd2257
Compare
Member
Author
|
Improved the PR after the merging of #14440 |
ndossche
requested changes
Jun 7, 2024
This doesn't really make the calling code clearer and it is barely used on top of that.
Girgias
force-pushed
the
spl-engine-remove
branch
from
3fd2257 to
573a363
Compare
ndossche
approved these changes
Jun 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't really make the calling code clearer and it is barely used on top of that.