Skip to content

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jun 1, 2024

Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible

Remove unused headers (such as php_ini.h for extensions that don't define INI settings)
Use more specific headers when possible
@Girgias Girgias force-pushed the ext-header-cleanup2 branch from 818f7ac to 320fc6b Compare June 1, 2024 18:24
@Girgias Girgias marked this pull request as ready for review June 1, 2024 18:58
Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok odbc

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pcntl/pgsql lctm

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for xml, xmlwriter, xsl, soap, simplexml

Copy link
Contributor

@alexdowad alexdowad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection for mbstring.

@Girgias Girgias merged commit fd2d869 into php:master Jun 8, 2024
@Girgias Girgias deleted the ext-header-cleanup2 branch June 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment