ext/pgsql: adding pg_change_password functionality. #14262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
May 20, 2024
ext/pgsql/pgsql.stub.php
Outdated
| function pg_result_memory_size(PgSql\Result $result): int {} | ||
| #endif | ||
|
|
||
| function pg_change_password(PgSql\Connection $connection, string $user, string $password): bool {} |
Member
There was a problem hiding this comment.
The password parameter should have the SensitiveParameter attribute
Member
Author
There was a problem hiding this comment.
ah very true I forgot about this.
handy call to change an user password while taking care transparently of the password's encryption.
Girgias
approved these changes
May 20, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
LGTM if CI is green, do not forget the UPGRADING entry. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handy call to change an user password while taking care transparently of the password's encryption.