pdo_firebird: use UNEXPECTED
#14064
Closed
pdo_firebird: use UNEXPECTED
#14064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
refacter_pdo_firebird
branch
from
c3d8270 to
bb8a279
Compare
SakiTakamachi
force-pushed
the
refacter_pdo_firebird
branch
from
bb8a279 to
b65e5e8
Compare
devnexen
reviewed
Apr 28, 2024
SakiTakamachi
force-pushed
the
refacter_pdo_firebird
branch
2 times, most recently
from
a562f49 to
0e5fd50
Compare
SakiTakamachi
changed the title
EXPECTED and UNEXPECTED
|
I decided not to include the change of if statement to switch in this PR. |
SakiTakamachi
force-pushed
the
refacter_pdo_firebird
branch
from
0e5fd50 to
ddb5572
Compare
SakiTakamachi
changed the title
EXPECTED and UNEXPECTEDUNEXPECTED
devnexen
reviewed
Apr 30, 2024
| case IS_NULL: | ||
| /* complain if this field doesn't allow NULL values */ | ||
| if (~var->sqltype & 1) { | ||
| if (UNEXPECTED(~var->sqltype & 1)) { |
There was a problem hiding this comment.
Globally looks correct to me, maybe this one (and the one above) kind of look a bit much. Not sure if there is a real gain but that s nitpicking :)
Girgias
approved these changes
Apr 30, 2024
|
Maybe I'll cut down on the changes quite a bit. When refactoring BCMath, I noticed that there were many places where using UNEXPECTED actually made the code slower. The usage is correct and may have hindered compiler optimizations. |
|
After measuring properly and identifying the areas that are effective, I will open the PR again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.