Simplify a do…while loop into a for one #13981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Apr 16, 2024
dstogov
requested changes
Apr 17, 2024
|
Readability? PHP's heap management code is complicated enough as it is without having contortions like his. The last time this code was touched, it was 10 years ago (by you). I do hope that compilers got better at improving trivial loops in the meantime. |
|
Optimizers work based on heuristics. It's really not possible to know whether some optimization is beneficial or detrimental without testing. Can you test whether this changes performance? |
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.