ext/bcmath: Remove rscale in bc_raisemod #13883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
bc_raisemod
branch
from
8311c56 to
f4eb134
Compare
power is a copy of base and returns early if base->n_scale is non-zero. Since scale is size_t, it is always greater than or equal to 0, so rscale is always the value of scale.
SakiTakamachi
force-pushed
the
bc_raisemod
branch
from
f4eb134 to
4984528
Compare
devnexen
approved these changes
Apr 7, 2024
|
Thanks for checking! yes, at the very least I'll check to see if there's anything I can improve. |
|
I thought it would change to merged status, but it didn't, so I closed it manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poweris a copy ofbaseand returns early ifbase->n_scaleis non-zero. Sincescaleissize_t, it is always greater than or equal to0, sorscaleis always the value ofscale.