ext/sockets: socket_create_listen update.

[devnexen]

going from 128 to system's SOMAXCONN by default to be able to increase the queue of connections to be handled.

[nielsdos]

I don't know what the real consequences are for applications that expect the default to be 128, and therefore don't pass the argument.

[devnexen]

The doc never mentions 128, it was kind of enough back in the day. However the doc does mention SOMAXCONN can be passed I just made it default. Besides, for Haiku, SOMAXCONN is 32.

[nielsdos]

Well, it looks like the docs have the 128 in the signature, so people could theoretically rely on that limit.
But that may not be of a big concern.
Anyway, that does mean though that this should be updated:

php-src/ext/sockets/sockets.stub.php

Line 1881 in 070ebbc

function socket_create_listen(int $port, int $backlog = 128): Socket|false {}

[kocsismate]

What about this?

Suggested change

	. socket_create_listen backlog argument default value had been changed to
	. Parameter $backlog of socket_create_listen() now has a default value of SOMAXCONN.
	Previously, it was 128.

[kocsismate]

LGTM! I cannot guess the BC impact of this change, but personally, I'm fine with it.

[devnexen]

I did similar-ish change in the rust std library about 2 years ago (and you can t even change the backlog value there), seems alright I m relatively confident. Anyhow, on libc like musl, SOMAXCONN is still 128 ;)

[nielsdos]

Okay, sounds good then; thanks!