Implement configure command visibility option for phpinfo #13742
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new --disable-configure-command option to optionally
suppress the display of the configure command in the phpinfo() output:
./configure --disable-configure-command
When building PHP, many packages have patches to hide the PHP build
configure command and its options in the phpinfo() output:
Configure Command: './configure' '--enable-foo' 'CFLAGS=...' '...'
This simplifies the PHP build process for package maintainers who prefer
more concise phpinfo() output without detailed build configuration.
The CONFIGURE_COMMAND symbol remains defined in the configuration
headers (main/build-defs.h for *nix, main/config.w32.h for Windows)
regardless of this option.
By default the configure command and options are displayed as before.
|
Makes sense, I might be more in favor of |
I know. --hide-configure-command :) Issue is that --with/--without is meant for things that require additional system dependency (package). I'll check how this could be made even simpler... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new --disable-configure-command option to optionally suppress the display of the configure command in the phpinfo() output:
When building PHP, many packages have patches to hide the PHP build configure command and its options in the phpinfo() output:
This simplifies the PHP build process for package maintainers who prefer more concise phpinfo() output without detailed build configuration.
The CONFIGURE_COMMAND symbol remains defined in the configuration headers (main/build-defs.h for *nix, main/config.w32.h for Windows) regardless of this option.
By default the configure command and options are displayed as before.