Spl object storage refactor #13666
Spl object storage refactor #13666
Conversation
Girgias
force-pushed
the
spl-object-storage-refactor
branch
from
e2b4e23 to
6945677
Compare
| @@ -1,5 +1,5 @@ | |||
| --TEST-- | |||
| SPL: ArrayObject | |||
| Bug #70053 (MutlitpleIterator array-keys incompatible change in PHP 7) | |||
| * need to convert it to just use a normal backing HashTable | ||
| * in the meantime we skip this whole block if it is this case. */ | ||
| if (parent == spl_ce_MultipleIterator) { | ||
| goto end; |
There was a problem hiding this comment.
It's now harder to follow the logic, I'm not sure this is an improvement.
If you fix this TODO and this code in a follow up then it's fine I think.
There was a problem hiding this comment.
I am planning to, but as I'm going on holiday I will leave this PR open so that I dont' forget about it.
|
I am closing this as I don't think using a normal HashTable for My initial idea was to use the "key" as the actual key and loop through the HashTable when attempting to remove an iterator, however this doesn't work as Using the object handle ID is not feasible either, and I don't think I'm comfortable using some other way to detect different objects (e.g. the pointer address of the object). |
2 participants
No description provided.