Skip to content

Fix GH-13217 Test failure with zlib-ng #13556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-13217 Test failure with zlib-ng #13556

wants to merge 1 commit into from

Conversation

@remicollet
Copy link
Member

As compressed result may be different

  • drop or relax expectations on compressed data
  • rely on uncompressed result of compressed data

@remicollet
Fix phpGH-13217 Test failure with zlib-ng
d3c23ba 
As compressed result may be different
- drop or relax expectations on compressed data
- rely on uncompressed result of compressed data
@remicollet
Copy link
Member Author

With zlib-ng 2.1.6

=====================================================================
Number of tests :  150               145
Tests skipped   :    5 (  3.3%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :  145 ( 96.7%) (100.0%)
---------------------------------------------------------------------
Time taken      :    0 seconds
=====================================================================

With zlib 1.2.13

=====================================================================
Number of tests :  150               145
Tests skipped   :    5 (  3.3%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :  145 ( 96.7%) (100.0%)
---------------------------------------------------------------------
Time taken      :    1 seconds
=====================================================================

@remicollet
Copy link
Member Author

remicollet commented Mar 5, 2024 •
edited
Loading

@Girgias thanks for the review

Merged in 8.2+ as 5e12844

@remicollet remicollet closed this Mar 5, 2024
@remicollet remicollet deleted the issue-zlib-ng branch March 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Category: Tests Extension: zlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remicollet @Girgias