Skip to content

Conversation

@georgebarbarosie
Copy link
Contributor

Fixes issue #13354

@devnexen
Copy link
Member

devnexen commented Feb 8, 2024

thanks. Now you need to add a test :-)

@georgebarbarosie
Copy link
Contributor Author

Apologies, I'm a first time contributor. I'll figure out how to write the test.

@devnexen
Copy link
Member

devnexen commented Feb 8, 2024

Could you do the following please ?

  • Renaming bug13354.phpt to gh13354.phpt.
  • Changing its reference from Bug #13354 to something like GH-13354.
  • Squashing all your commits into one.
    Sorry I forgot to tell you, you could not really know.

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I just need to pay attention with your test and the master branch but you do not need to worry :)

@devnexen devnexen closed this in 452e008 Feb 8, 2024
devnexen added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants