GitHub Actions: Add a timeout to Caddy server download #13295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `caddyserver.com/api/download` times out, which causes all our CI runs on Linux to fail after trying for 30 seconds. Further, the caddy website also mentions the site is experiencing issues and there is no SLA. Ideally, we are probably better off using Caddy's GitHub Releases page, but the URL patterns are difficult to build, so this timeout tries to reduce the CI jobs waiting nearly 30 minutes before giving up.
|
@Ayesh I was about to apply this for PHP 8.1+, what a terrible waste of resources waiting for the 50 minute hard timeout. Is there a reason you closed this? |
|
This looks fine to me. It could even make sense to make this step fallible, as there's no reason to skip all tests for the few caddy tests. We should still see the fact this step fails in the job overview. Tbh these curl defaults are kind of bonkers. |
|
I thought I closed fast enough to not bother you @TimWolla / @iluuu1994 .. I'm sorry. I asked some people at Caddy what's going on, and they recommended to use GitHub Releases over caddyserver.com to download binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
caddyserver.com/api/downloadtimes out, which causes all our CI runs on Linux to fail after trying for 30 seconds.Further, the caddy website also mentions the site is experiencing issues and there is no SLA.
Ideally, we are probably better off using Caddy's GitHub Releases page, but the URL patterns are difficult to build, so this timeout tries to avoid the CI jobs waiting nearly 30 minutes before giving up. This change adds 120 second hard timeout, and adds three retries 10 seconds apart.