ext/curl: Update sync_constants.php const matching to uncover more constants
#13282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constants The `sync_constants.php` file uncovers constants present in libcurl source, but\ not present in PHP ext/curl source. There is a regular expression to match Curl constants, but to it did not previously include `CURLE_*` and `CURLINFO_*` constants, which PHP should expose as constants. This updates the `sync_constants.php` file's constant filter regex to expose those constants patterns as well. The new missing constants will be added in a later PR.
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. 1: https://curl.se/libcurl/c/libcurl-errors.html 2: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 7, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 7, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 7, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 11, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 12, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 16, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 19, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 19, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Apr 10, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sync_constants.phpfile uncovers constants present in libcurl source, but not present in PHP ext/curl source. There is a regular expression to match Curl constants, but to it did not previously includeCURLE_*andCURLINFO_*constants, which PHP should expose as constants.This updates the
sync_constants.phpfile's constant filter regex to expose those constants patterns as well. The new missing constants will be added in a later PR.