Remove HAVE_JSON symbol #13277
Merged
Remove HAVE_JSON symbol #13277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The json extension is always available as of php 8.0. HAVE_JSON was also never defined for Windows builds.
devnexen
approved these changes
Jan 31, 2024
bukka
approved these changes
Jan 31, 2024
|
Ok, I'll merge this and also look around the extensions ecosystem a bit if there are fixes needed somewhere. So far I've located only Phalcon and nothing major actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json extension is always available as of php 8.0. HAVE_JSON was also never defined for Windows builds.
I'd simply remove this in PHP-8.4, otherwise I can wait with this PR for PHP-9.0 if it's too early for this...