Add ReflectorWithAttributes interface with getFirstAttribute() and hasAttribute() #13224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onAbstract::getAttribute method
|
I have absolutely no idea why the tests aren't passing on 3 of the 5 platforms, but I'll continue for now. |
# Conflicts: # ext/reflection/php_reflection_arginfo.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at introducing the interface
ReflectorWithAttributeswhich is implemented by the following classes:ReflectionFunctionAbstractReflectionParameterReflectionClassReflectionPropertyThe
getAttributes()method present all of the above has been moved to this new interface, and the following methods have been added:getFirstAttribute(?string $name = null, int $flags = 0): ?ReflectionAttributehasAttribute(?string $name = null, int $flags = 0): boolI've tried to work with what is currently there, rather than replacing the current approach to attributes, but I can't speak for efficiency and such, so would appreciate any feedback.
This PR is an implementation of #8489, which was mentioned on the mailing list with little to no feedback.