Refactor file_put_contents() type handling #13206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Come to think of it, the array case is perhaps a good opportunity to save on system calls using the vector write API from Linux: https://linux.die.net/man/3/writev |
bukka
reviewed
Feb 3, 2024
| } | ||
| if (ZSTR_LEN(entry_str)) { | ||
| // Append to smart string | ||
| smart_str_append(&smart_str, entry_str); |
There was a problem hiding this comment.
So previously we wrote it directly to the streams and now smart_str is used. It seems to me that this can result in more to be used at a single point which might not be ideal especially if you have got lots of items in the array. This seems like a potential regression to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to align the behaviour of
$dataas if we had a ZPP check for it, as such passingnullis deprecated and non stringable objects throw an Error.Another addition is to check that all entries of an array are actually strings and pre-concatenating them to save on IO calls (and actually do what the docs say passing an array does).