Fix GH-13142: Undefined variable name is shortened when contains \0 #13200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Engine
Extension: opcache
Extension: standard
labels
nielsdos
changed the title
mvorisek
reviewed
Jan 20, 2024
| abort(); | ||
| } | ||
|
|
||
| ZEND_API ZEND_COLD ZEND_NORETURN void zend_error_noreturn_unchecked(int type, const char *format, ...) |
There was a problem hiding this comment.
what is the point of this function, it is 1:1 as zend_error_noreturn above
There was a problem hiding this comment.
I see, ZEND_ATTRIBUTE_FORMAT in .h
| --FILE-- | ||
| <?php | ||
|
|
||
| $a = "test\0test"; |
There was a problem hiding this comment.
It might be better if there were also tests in the case of \0test and test\0
|
Thank you for adding the test case. |
|
Merged in fe064d7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new %S modifier I introduced in 8d5c3e6
Also makes changes to php_verror such that it can handle strings containing \0