Skip to content

missing SKIP_SLOW_TESTS #13156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024
Merged

missing SKIP_SLOW_TESTS #13156

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47e7783
missing SKIP_SLOW_TESTS
divinity76 Jan 15, 2024
d7fe440
skip message nitpick
divinity76 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ext/standard/tests/general_functions/proc_open_sockets1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
--TEST--
proc_open() with output socketpairs
--SKIPIF--
<?php
if (getenv("SKIP_SLOW_TESTS")) die("SKIP_SLOW_TESTS");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message must start with skip ... or it won't actually be skipped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually it will, likely by accident. The regex is /^skip\s*(.+)/i instead of /^skip\s+(.+)/i. Anyway, please stick to the existing convention.

Copy link
Contributor Author

@divinity76 divinity76 Jan 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the existing convention

you sure there is one?

sapi/fpm/tests/reload-uses-sigkill-as-last-measure.phpt:

if (getenv('SKIP_SLOW_TESTS')) die('skip slow tests excluded by request');

tests/basic/timeout_variation_9.phpt:

if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");

ext/phar/tests/bug13727.phpt:

<?php if (getenv('SKIP_SLOW_TESTS')) die('skip'); ?>

ext/sockets/tests/socket_shutdown-win32.phpt:

if (getenv("SKIP_SLOW_TESTS")) {
    die('skip: Slow test');
}

ext/curl/tests/bug64267.phpt:

if (getenv("SKIP_ONLINE_TESTS")) die("skip online test");

ext/soap/tests/bug69137.phpt:

if (getenv("SKIP_ONLINE_TESTS")) { die("skip test requiring internet connection"); }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we're inconsistent. That doesn't mean we need yet another variation 😉

?>
--FILE--
<?php

Expand Down