Skip to content

Conversation

@divinity76
Copy link
Contributor

gethostbynamel may contact DNS servers, so it should be skipped if SKIP_ONLINE_TESTS , and on a AMD Ryzen 9 7950x WSL Ubuntu this test took ~2 seconds (some DNS timeout i guess?) so it should also have SKIP_SLOW_TESTS

gethostbynamel may contact DNS servers, so it should be skipped if SKIP_ONLINE_TESTS , and on a AMD Ryzen 9 7950x WSL Ubuntu this test took ~2 seconds (some DNS timeout i guess?) so it should also have SKIP_SLOW_TESTS
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in #13156, please stick to the standard message.

@divinity76
Copy link
Contributor Author

divinity76 commented Jan 17, 2024

@iluuu1994

the standard message.

you sure there is one?

sapi/fpm/tests/reload-uses-sigkill-as-last-measure.phpt:

if (getenv('SKIP_SLOW_TESTS')) die('skip slow tests excluded by request');

tests/basic/timeout_variation_9.phpt:

if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");

ext/phar/tests/bug13727.phpt:

<?php if (getenv('SKIP_SLOW_TESTS')) die('skip'); ?>

ext/sockets/tests/socket_shutdown-win32.phpt:

if (getenv("SKIP_SLOW_TESTS")) {
    die('skip: Slow test');
}

ext/curl/tests/bug64267.phpt:

if (getenv("SKIP_ONLINE_TESTS")) die("skip online test");

ext/soap/tests/bug69137.phpt:

if (getenv("SKIP_ONLINE_TESTS")) { die("skip test requiring internet connection"); }

@iluuu1994 iluuu1994 merged commit 822769f into php:master Jan 17, 2024
@iluuu1994
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants