Skip to content

Fix GH-12962: Double free of init_file in phpdbg_prompt.c #12963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix GH-12962: Double free of init_file in phpdbg_prompt.c #12963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sapi/phpdbg/phpdbg_prompt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ void phpdbg_init(char *init_file, size_t init_file_len, bool use_default) /* {{{
}

ZEND_IGNORE_VALUE(asprintf(&init_file, "%s/%s", scan_dir, PHPDBG_INIT_FILENAME));
phpdbg_try_file_init(init_file, strlen(init_file), 1);
phpdbg_try_file_init(init_file, strlen(init_file), 0);
free(init_file);
if (i == -1) {
break;
Expand Down
13 changes: 13 additions & 0 deletions sapi/phpdbg/tests/gh12962.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
--TEST--
GH-12962 (Double free of init_file in phpdbg_prompt.c)
--SKIPIF--
<?php
if (!getenv('TEST_PHPDBG_EXECUTABLE')) die("SKIP: No TEST_PHPDBG_EXECUTABLE specified");
?>
--FILE--
<?php
putenv('PHP_INI_SCAN_DIR='.__DIR__."/gh12962");
passthru($_ENV['TEST_PHPDBG_EXECUTABLE'] . " -q");
?>
--EXPECT--
Executed .phpdbginit
2 changes: 2 additions & 0 deletions sapi/phpdbg/tests/gh12962/.phpdbginit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ev "Executed .phpdbginit"
q